Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate prefect tasks #483

Merged
merged 4 commits into from
Sep 6, 2024
Merged

deprecate prefect tasks #483

merged 4 commits into from
Sep 6, 2024

Conversation

ryanSoley
Copy link
Member

@ryanSoley ryanSoley commented Sep 4, 2024

What

deprecates the rubicon_ml.workflow module, only containing prefect tasks. rubicon-ml can still be used within custom prefect tasks as it normally would be

  • these tasks have not been updated in over 3 years and are minimally leveraged by users
  • they can be simply recreated, as shown in the updated example notebook that will remain in the docs
  • frequent major updates to prefect have caused conflicts and vulnerabilities we no longer want to deal with inside rubicon-ml by having prefect as a dependency

How to Test

  • python -m pytest

@ryanSoley ryanSoley requested review from a team as code owners September 4, 2024 14:23
@ryanSoley ryanSoley self-assigned this Sep 4, 2024
@ryanSoley ryanSoley added the development Issues that require technical work. Associated PRs are required. label Sep 4, 2024
@ryanSoley
Copy link
Member Author

after this is merged and released, a followup will remove the tasks.py file and the prefect dependency from the setup, requirements, and environments

Copy link
Contributor

@shania-m shania-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanSoley ryanSoley merged commit 32d1a83 into main Sep 6, 2024
7 checks passed
@ryanSoley ryanSoley deleted the deprecate-prefect-tasks branch September 6, 2024 14:24
@ryanSoley ryanSoley mentioned this pull request Sep 20, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Issues that require technical work. Associated PRs are required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants