Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for logging of H2O MOJO Models #486

Merged
merged 10 commits into from
Sep 30, 2024
Merged

Add support for logging of H2O MOJO Models #486

merged 10 commits into from
Sep 30, 2024

Conversation

thebrianbn
Copy link
Contributor

What

  • Adds support for saving and logging of H2O MOJO models, in addition to the support of binary models
  • Update get_data to handle deserialization of H2O MOJO models
  • Unit tests updated/added to test for logging of H2O MOJO models

How to Test

  • python -m pytest tests/unit
  • python -m pytest tests/integration/test_schema.py

@thebrianbn thebrianbn requested review from a team as code owners September 26, 2024 17:43
@CLAassistant
Copy link

CLAassistant commented Sep 26, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

dianelee217
dianelee217 previously approved these changes Sep 26, 2024
View reviewed changes
ryanSoley
ryanSoley reviewed Sep 30, 2024
View reviewed changes
Copy link
Member

@ryanSoley ryanSoley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks great! just one comment for backwards compatibility

rubicon_ml/client/artifact.py Outdated Show resolved Hide resolved
ryanSoley
ryanSoley approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@ryanSoley ryanSoley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

rubicon_ml/client/artifact.py
warnings.warn(
"'deserialize' method 'h2o' will be deprecated in a future release,"
" please use 'h2o_binary' instead.",
DeprecationWarning,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@thebrianbn thebrianbn merged commit 6f22bce into capitalone:main Sep 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanSoley ryanSoley ryanSoley approved these changes

@dianelee217 dianelee217 Awaiting requested review from dianelee217

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thebrianbn @CLAassistant @ryanSoley @dianelee217