Make IndexMove private and unsafely implement it for all lists
#292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some sense it acts as a `get_unchecked` method but is not exposed publicly anymore to prevent rogue implementations.
|
If I understand correctly, the purpose of this is to make it so that iterator-based access to capnproto lists avoids bounds checks. Have you experimentally observed a significant improvement from this change? I'm somewhat reluctant to add more instances of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some sense it acts as a
get_uncheckedmethod but is notexposed publicly anymore to prevent rogue implementations.