Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Remove RefCell from builder arena #363

Closed
wants to merge 6 commits into from
Closed

[RFC] Remove RefCell from builder arena #363

wants to merge 6 commits into from

Commits on Jan 14, 2023

  1. Store an Allocator directly in BuilderArenaImplInner

    @marmeladema
    marmeladema committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    9eb9cd4 View commit details
    Browse the repository at this point in the history

  2. BuilderArenaImplInner::allocate_segment is not actually fallible

    @marmeladema
    marmeladema committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    c4b96cc View commit details
    Browse the repository at this point in the history

  3. Add BuilderSegment::allocate and use it where it makes sense

    @marmeladema
    marmeladema committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    a637bbe View commit details
    Browse the repository at this point in the history

  4. Always allocate memory when creating a new segment 

    There were only two calls to `BuilderArenaImplInner::allocate_segment`
and they were both followed by a call to `BuilderArenaImplInner::allocate`.
    @marmeladema
    marmeladema committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    b6f6931 View commit details
    Browse the repository at this point in the history

  5. Return segment id for BuilderArenaImplInner::allocate_segment

    @marmeladema
    marmeladema committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    83a1047 View commit details
    Browse the repository at this point in the history

  6. Remove RefCell from builder arena

    @marmeladema
    marmeladema committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    66198dd View commit details
    Browse the repository at this point in the history