Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: toggle phone number registration #1157

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat: toggle phone number registration #1157

wants to merge 3 commits into from

Conversation

jackdishman
Copy link
Contributor

No description provided.

@jackdishman
Copy link
Contributor Author

Closes #1156

@jackdishman jackdishman linked an issue Aug 30, 2022 that may be closed by this pull request
Ability to toggle phone number verification #1156
Open
ashutosh1206
ashutosh1206 suggested changes Sep 1, 2022
View reviewed changes
src/backend/funder.ts
@@ -2,6 +2,13 @@ import axios from 'axios'
import { checkAccountStatus, getIsAccountIdOnboarded } from './near'
import { capsuleServer, sufficientFunds } from './utilities/config'

export async function requestOTP(phoneNumber: string) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also add a captchaRes to requestOTP() function. Basically, when phone number toggle is on, we want the user to solve captcha when request for an OTP from their phone number (ie. requestOTP() function)

@ashutosh1206
Copy link
Contributor

We also might have to disable/skip captcha verification on select-username step if phone number toggle is enabled, since captcha verification happens on enter-phone-number step in that case

@jackdishman
Copy link
Contributor Author

Pulled from backend channel:

  1. User enters phone number
  2. User presses "Send Code"
  3. Captcha appears, User solves captcha
  4. User enters OTP code
  5. User enters the new id and registers

@chrispanag chrispanag changed the title feat: toggle phone number registeration feat: toggle phone number registration Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashutosh1206 ashutosh1206 ashutosh1206 requested changes

@chrispanag chrispanag Awaiting requested review from chrispanag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to toggle phone number verification
2 participants
@jackdishman @ashutosh1206