Skip to content

Commit

Permalink
fix(mlflow): Change default extra envs field type in Mlflow config va…
Browse files Browse the repository at this point in the history
…lues to list (#432)
  • Loading branch information
deadlycoconuts authored Jan 9, 2025
1 parent daafd17 commit 2bee3bf
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 13 deletions.
2 changes: 1 addition & 1 deletion charts/merlin/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,4 @@ maintainers:
- email: [email protected]
name: caraml-dev
name: merlin
version: 0.13.23
version: 0.13.24
4 changes: 2 additions & 2 deletions charts/merlin/README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# merlin

---
![Version: 0.13.23](https://img.shields.io/badge/Version-0.13.23-informational?style=flat-square)
![Version: 0.13.24](https://img.shields.io/badge/Version-0.13.24-informational?style=flat-square)
![AppVersion: v0.42.0](https://img.shields.io/badge/AppVersion-v0.42.0-informational?style=flat-square)

Kubernetes-friendly ML model management, deployment, and serving.
Expand Down Expand Up @@ -316,7 +316,7 @@ The following table lists the configurable parameters of the Merlin chart and th
| mlflow.artifactRoot | string | `"/data/artifacts"` | |
| mlflow.artifactServiceType | string | `"nop"` | |
| mlflow.deploymentLabels | object | `{}` | |
| mlflow.extraEnvs | object | `{}` | |
| mlflow.extraEnvs | list | `[]` | |
| mlflow.host | string | `"0.0.0.0"` | |
| mlflow.image.pullPolicy | string | `"Always"` | |
| mlflow.image.registry | string | `"ghcr.io"` | |
Expand Down
22 changes: 12 additions & 10 deletions charts/merlin/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -533,11 +533,6 @@ mlflow:
## does not impact already-created experiments.
#
artifactRoot: "/data/artifacts"
## Use this field to add environment variables relevant to MLflow server.
## These fields will be passed on to MLflow container(s) when Chart is deployed.
#
# extraEnvs:
# FOO: bar

## The network address to listen on (default:
## 127.0.0.1). Use 0.0.0.0 to bind to all
Expand Down Expand Up @@ -577,12 +572,19 @@ mlflow:
# orchestrator: unknown

# Add the following configs when you wish to point to an actual S3 for mlflow to store its artifacts
extraEnvs: {}
# AWS_ACCESS_KEY_ID: YOURACCESSKEY
# AWS_SECRET_ACCESS_KEY: YOURSECRETKEY
# AWS_DEFAULT_REGION: ap-southeast-2
## Use this field to add environment variables relevant to MLflow server.
## These fields will be passed on to MLflow container(s) when Chart is deployed.
extraEnvs: []
# - name: AWS_ACCESS_KEY_ID
# value: YOURACCESSKEY
# - name: AWS_SECRET_ACCESS_KEY
# value: YOURSECRETKEY
# - name: AWS_DEFAULT_REGION
# value: ap-southeast-2
# Instead of this env variable minio.enabled should be used:
# MLFLOW_S3_ENDPOINT_URL: http://minio.minio.svc.cluster.local:9000
# - name: MLFLOW_S3_ENDPOINT_URL
# value: http://minio.minio.svc.cluster.local:9000

# If you would like to use an external postgres database for MLflow, you can connect using these credentials
mlflowExternalPostgresql:
# -- If you would like to use an external postgres database, enable it here using this
Expand Down

0 comments on commit 2bee3bf

Please sign in to comment.