Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(merlin): Fix merlin batch job node selector default value #408

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

ariefrahmansyah
Copy link
Contributor

Motivation

Merlin's default values.yaml has BatchConfig.NodeSelectors value configured which will no be overwritten if user modify the value on their own values file.

Modification

  1. Remove BatchConfig.NodeSelectors default value
  2. Update default value for imageBuilder.builderConfig.PredictionJobBaseImage.MainAppPath

Checklist

  • Chart version bumped
  • README.md updated

@ariefrahmansyah ariefrahmansyah requested a review from a team as a code owner March 20, 2024 07:52
@ariefrahmansyah ariefrahmansyah changed the title Fix merlin batch job node selector default value chore(merlin): Fix merlin batch job node selector default value Mar 20, 2024
Copy link
Contributor

@deadlycoconuts deadlycoconuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 Thanks for the changes!

@ariefrahmansyah ariefrahmansyah merged commit eee6c6c into main Mar 20, 2024
3 checks passed
@ariefrahmansyah ariefrahmansyah deleted the fix-merlin-batch-job-node-selector branch March 20, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants