Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(serving): adding startup and readiness probe #420

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

bayu-aditya
Copy link
Collaborator

@bayu-aditya bayu-aditya commented Aug 20, 2024

Motivation

The Caraml Store Serving service needs to maintain high availability due to the large volume of requests it handles. Therefore, it's crucial to ensure the application has completed its startup process using a startup probe. Additionally, if the service becomes unresponsive for an extended period, the pod should be restarted using a liveness probe.

Modification

Adding startup and liveness probe for caraml store serving deployments with default value

startupProbe:
  httpGet:
    path: /actuator/health
    port: 8080
  periodSeconds: 5
  timeoutSeconds: 1
  failureThreshold: 10
livenessProbe:
  httpGet:
    path: /actuator/health
    port: 8080
  initialDelaySeconds: 0
  periodSeconds: 10
  timeoutSeconds: 2
  failureThreshold: 5

Checklist

  • Chart version bumped
  • README.md updated

@bayu-aditya bayu-aditya requested a review from a team as a code owner August 20, 2024 06:26
@bayu-aditya bayu-aditya changed the title Adding startup and readiness probe for Store Serving feat(serving): adding startup and readiness probe Aug 20, 2024
@bayu-aditya bayu-aditya force-pushed the bayu/caraml-store-serving-liveness branch 3 times, most recently from 0329e0a to 24f3114 Compare August 20, 2024 07:29
@bayu-aditya bayu-aditya self-assigned this Aug 20, 2024
charts/caraml-store/values.yaml Outdated Show resolved Hide resolved
charts/caraml-store/values.yaml Outdated Show resolved Hide resolved
charts/caraml-store/values.yaml Outdated Show resolved Hide resolved
charts/caraml-store/values.yaml Outdated Show resolved Hide resolved
charts/caraml-store/values.yaml Outdated Show resolved Hide resolved
@bayu-aditya bayu-aditya force-pushed the bayu/caraml-store-serving-liveness branch from 24f3114 to 874e185 Compare August 21, 2024 02:30
@bayu-aditya
Copy link
Collaborator Author

bayu-aditya commented Aug 21, 2024

Thanks for your feedback @tiopramayudi. For all reviews already resolved in 874e185 🙏

@bayu-aditya bayu-aditya requested a review from shydefoo August 23, 2024 04:29
@bayu-aditya bayu-aditya merged commit 237509a into main Aug 28, 2024
3 checks passed
@bayu-aditya bayu-aditya deleted the bayu/caraml-store-serving-liveness branch August 28, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants