test(e2e-storybook): fix feature-card e2e skipped tests and make them… #12130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-amorim
requested review from
m4olivei,
marcelojcs,
andy-blum and
Valentin-Sorin-Nicolae
✅ Deploy Preview for ibm-dotcom-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-dotcom-web-components-react-wrap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bruno-amorim
commented
Nov 28, 2024
| @@ -96,7 +96,7 @@ export const Large = (args) => { | |||
| </c4d-image> | |||
| <c4d-card-eyebrow>${eyebrow}</c4d-card-eyebrow> | |||
| <c4d-card-heading>${heading}</c4d-card-heading> | |||
| ${copy && html`<p></p>`} | |||
| ${copy ? html`<p>${copy}</p>` : ''} | |||
There was a problem hiding this comment.
In the storybook the large variation wasn't having a paragraph with copy, it was empty instead. As per Figma this large variation always has a copy, so I added that conditionally for our tests to correctly do their checkage. Thanks!
m4olivei
approved these changes
Nov 29, 2024
andy-blum
added
the
Ready to merge
andy-blum
approved these changes
Dec 2, 2024
deathcave
pushed a commit
to deathcave/carbon-for-ibm-dotcom
that referenced
this pull request
Dec 4, 2024
carbon-design-system#12130) … valid ### Related Ticket(s) Closes # [carbon-design-system/issues/12121](carbon-design-system#12121) ### Description The e2e-storybook tests have been failing for quite awhile. The tests do not appear to have been updated for v2. In many cases, the tests are using the old v1 prefixes. The goal here is: - Fix all skipped tests and align them with what we have in v2. ### Changelog **New** - Updated e2e-storybook for feature-card component so that all skipped tests are now running and correctly and doing the proper checkage
andy-blum
pushed a commit
that referenced
this pull request
Dec 4, 2024
#12130) … valid ### Related Ticket(s) Closes # [/issues/12121](#12121) ### Description The e2e-storybook tests have been failing for quite awhile. The tests do not appear to have been updated for v2. In many cases, the tests are using the old v1 prefixes. The goal here is: - Fix all skipped tests and align them with what we have in v2. ### Changelog **New** - Updated e2e-storybook for feature-card component so that all skipped tests are now running and correctly and doing the proper checkage
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… valid
Related Ticket(s)
Closes #
/issues/12121
Description
The e2e-storybook tests have been failing for quite awhile. The tests do not appear to have been updated for v2. In many cases, the tests are using the old v1 prefixes.
The goal here is:
Changelog
New