Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): upgrade to Percy Storybook v4 [DO NOT MERGE] #8128

Closed
wants to merge 22 commits into from
Closed

chore(deps): upgrade to Percy Storybook v4 [DO NOT MERGE] #8128

wants to merge 22 commits into from

Conversation

jeffchew
Copy link
Member

@jeffchew jeffchew commented Jan 24, 2022 •
edited
Loading

Related Ticket(s)

No related issue

Description

This is another attempt to upgrade to Percy Storybook v4.

This is currently blocked, as Percy CLI is not rendering properly with web components. There is a possible feature coming through as a config, being tracked here:
percy/cli#280

Issues related to Percy Storybook SDK, currently tracked in the discussion here:
percy/percy-storybook#566

Changelog

Changed

  • Upgrade @percy dependencies to latest versions
  • Suppress percy skip for FeatureSection and TabsExtended in React

@jeffchew jeffchew added the dev Needs some dev work label Jan 24, 2022
@jeffchew jeffchew requested a review from a team as a code owner January 24, 2022 14:55
@jeffchew jeffchew self-assigned this Jan 24, 2022
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 24, 2022 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/8128/index.html

Built with commit: 8e4bd1ead41a70b33b3d80d1a7ea671bd210852f

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 24, 2022 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8128/index.html

Built with commit: 8e4bd1ead41a70b33b3d80d1a7ea671bd210852f

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 24, 2022 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8128/index.html

Built with commit: 8e4bd1ead41a70b33b3d80d1a7ea671bd210852f

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 24, 2022 •
edited
Loading

Deploy preview created for package NextJS Test Application:
https://ibmdotcom-nextjs-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8128/index.html

Built with commit: 8e4bd1ead41a70b33b3d80d1a7ea671bd210852f

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 24, 2022 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8128/index.html

Built with commit: 8e4bd1ead41a70b33b3d80d1a7ea671bd210852f

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 24, 2022 •
edited
Loading

Deploy preview created for package "Web Components (Codesandbox Examples)":
https://webcomponents-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8128/index.html

Built with commit: 818a382abe23ca8b834a25d754ef9a6cfa9e49a9

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 24, 2022 •
edited
Loading

Deploy preview created for package "React (Codesandbox Examples)":
https://react-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8128/index.html

Built with commit: 818a382abe23ca8b834a25d754ef9a6cfa9e49a9

kennylam
kennylam approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @jeffchew!

packages/react/.storybook/preview-head.html Outdated
@@ -744,7 +745,7 @@
</script>

<!-- IBM Tag Management and Site Analytics -->
<script src="//1.www.s81c.com/common/stats/ibm-common.js" defer></script>
<!--<script src="//1.www.s81c.com/common/stats/ibm-common.js" defer></script>-->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just remove this? If not, maybe a short comment why it's commented out (same goes for the line in packages/web-components/.storybook/preview-head.html) ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should remove it entirely, it's been causing issues with Percy CLI for properly capturing snapshots while waiting for a bunch fo ad scripts loading on the page.

@jeffchew
Copy link
Member Author

jeffchew commented Feb 18, 2022 •
edited
Loading

LGTM thanks @jeffchew!

Thanks for approving @kennylam ! We need to hold off on merging this though because a lot of snapshots are not loading properly due to using the Percy CLI instead of how it's currently being captured in Percy Storybook v3:

Web Components missing 81 snapshots:
image

React missing 57 snapshots:
image

I have an open support ticket with the Browserstack Percy team for this, which they are actively investigating now.

@jeffchew jeffchew changed the title chore(deps): upgrade to Percy Storybook v4 chore(deps): upgrade to Percy Storybook v4 [DO NOT MERGE] Feb 18, 2022
@jeffchew
Copy link
Member Author

Updated to beta 76. Still a lot of missing snapshots:

image

jeffchew added 4 commits April 18, 2022 15:46
@jeffchew
Merge branch 'main' into chore/upgrade-percy-sb
a0a1e56 
# Conflicts:
#	packages/react/package.json
#	packages/web-components/package.json
#	yarn.lock
@jeffchew
chore(yarn): update offline mirror
0927ad2
@jeffchew
Merge branch 'main-upstream' into chore/upgrade-percy-sb
6bddc76 
# Conflicts:
#	packages/react/package.json
#	packages/web-components/package.json
#	yarn.lock
@jeffchew
chore(deps): bump percy to v1.2.0
8e4bd1e
@jeffchew jeffchew mentioned this pull request May 17, 2022
Closed
@jeffchew
Copy link
Member Author

jeffchew commented Jul 7, 2022

Closing this PR as it's pretty out of sync with main. Will open a new PR.

@jeffchew jeffchew closed this Jul 7, 2022
This was referenced Jul 7, 2022
Closed
Closed
@jeffchew
Copy link
Member Author

jeffchew commented Jul 8, 2022

New PR here: #9068

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennylam kennylam kennylam approved these changes

@oliviaflory oliviaflory Awaiting requested review from oliviaflory oliviaflory is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees

@jeffchew jeffchew

Labels
dev Needs some dev work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffchew @ibmdotcom-bot @kennylam