Fix crash when driver fuzzer finds language-server. (#4847)

The driver fuzzer, unlike the actual driver, provides a null `input_stream`, which caused the `language-server` subcommand to crash.
carbon-language · Jan 27, 2025 · 809c532 · 809c532
1 parent 3d39ab6
commit 809c532
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/toolchain/driver/driver_test.cpp b/toolchain/driver/driver_test.cpp
@@ -228,5 +228,10 @@ TEST_F(DriverTest, FileOutput) {
   EXPECT_THAT(ReadFile("test.s"), ContainsRegex("Main:"));
 }
 
+TEST_F(DriverTest, LanguageServerNoStdin) {
+  EXPECT_FALSE(driver_.RunCommand({"language-server"}).success);
+  EXPECT_THAT(test_error_stream_.TakeStr(), HasSubstr("requires input_stream"));
+}
+
 }  // namespace
 }  // namespace Carbon
diff --git a/toolchain/driver/language_server_subcommand.cpp b/toolchain/driver/language_server_subcommand.cpp
@@ -22,6 +22,7 @@ auto LanguageServerSubcommand::Run(DriverEnv& driver_env) -> DriverResult {
   if (!driver_env.input_stream) {
     *driver_env.error_stream
         << "error: language-server requires input_stream\n";
+    return {.success = false};
   }
 
   auto err =