Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SemIR naming of import_refs #4824

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

clavin
Copy link
Contributor

@clavin clavin commented Jan 20, 2025

Changes the name of SemIR import_refs to use the format <package>.<entity>.

BeforeAfter
%import_ref.05a: type %Main.D: type
%import_ref.8f2: <witness> %Main.import_ref.8f2: <witness>

@github-actions github-actions bot requested a review from zygoloid January 20, 2025 19:55
@clavin clavin force-pushed the improve_import_ir_name branch from afeb1aa to 603e6ec Compare January 21, 2025 17:03
Copy link
Contributor

@zygoloid zygoloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is definitely making the IR substantially more readable.

@zygoloid zygoloid enabled auto-merge January 22, 2025 00:23
auto-merge was automatically disabled January 22, 2025 03:33

Head branch was pushed to by a user without write access

@clavin clavin force-pushed the improve_import_ir_name branch from 603e6ec to 265648f Compare January 22, 2025 03:33
@zygoloid zygoloid added this pull request to the merge queue Jan 22, 2025
Merged via the queue into carbon-language:trunk with commit 3f4de65 Jan 22, 2025
8 checks passed
@clavin clavin deleted the improve_import_ir_name branch January 22, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve SemIR naming of import_refs
2 participants