Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade starknet 2.6.0, Snfoundry 0.26.0 #115

Merged
merged 9 commits into from
Jul 22, 2024

Conversation

julienbrs
Copy link
Collaborator

@julienbrs julienbrs commented Jul 17, 2024

closes #85
Updated Scarb to 2.6.0, snfoundry to 0.26.0, which led to changes like start_cheat_caller_address, declare and deploy,... Changes related to events assertions will me made in #111.
Also updated Readme and CI, so tests runs more often

@julienbrs julienbrs requested a review from tekkac July 17, 2024 10:15
@julienbrs julienbrs self-assigned this Jul 17, 2024
tekkac
tekkac previously approved these changes Jul 19, 2024
Copy link
Contributor

@tekkac tekkac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

minor notes:

  • we might need to keep times, or at least the starting year in a storage var
  • scarb version should be gotten from .tool-versions

@julienbrs
Copy link
Collaborator Author

lgtm

minor notes:

  • we might need to keep times, or at least the starting year in a storage var
  • scarb version should be gotten from .tool-versions
  • Starting_year can easily be fetched, it's the year of the first vintage. Do we really need to use a storage var? If we really want a getter, we can create a function that does the fetch and return the .year, what do you think?
  • Removed .tool-versions from gitignore

@julienbrs julienbrs merged commit ac6935b into carbonable-labs:main Jul 22, 2024
2 checks passed
@julienbrs julienbrs deleted the upgrade-starknet-2.6.0 branch July 22, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Starknet version
2 participants