Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Metadata handler #119

Merged
merged 6 commits into from
Jul 24, 2024
Merged

Feat: Metadata handler #119

merged 6 commits into from
Jul 24, 2024

Conversation

tekkac
Copy link
Contributor

@tekkac tekkac commented Jul 21, 2024 •
edited
Loading

Implement PoC Metadata Handler for cpv3

  • reuses v2 component provider.
  • Metadata is implemented is carbonable/metadata
  • Might need to create separate metadata repo for v3

@tekkac tekkac marked this pull request as ready for review July 23, 2024 06:02
@julienbrs julienbrs self-requested a review July 23, 2024 06:47
julienbrs
julienbrs approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@julienbrs julienbrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Svg on-chain goes brrr 🕺✨

@julienbrs julienbrs merged commit 2f264a7 into carbonable-labs:main Jul 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienbrs julienbrs julienbrs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tekkac @julienbrs