Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Metadata component #45

Merged
merged 6 commits into from
May 27, 2024
Merged

Feat: Metadata component #45

merged 6 commits into from
May 27, 2024

Conversation

tekkac
Copy link
Contributor

@tekkac tekkac commented May 2, 2024 •
edited
Loading

fix #26

  • Need to import the components in the project contract

@tekkac tekkac changed the title Feat/metadata component Feat: Metadata component May 2, 2024
cloudvenger
cloudvenger reviewed May 3, 2024
View reviewed changes
Copy link
Collaborator

@cloudvenger cloudvenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM just a comment on naming

src/components/metadata.cairo Outdated Show resolved Hide resolved
@tekkac tekkac merged commit 161f33b into carbonable-labs:main May 27, 2024
1 check passed
@tekkac tekkac deleted the feat/metadata-component branch May 27, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudvenger cloudvenger cloudvenger left review comments

@julienbrs julienbrs julienbrs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[OpenZepplin] Overcharge Metadata URI from ERC-1155 to set URI per Vintage
3 participants
@tekkac @cloudvenger @julienbrs