feat: different error handling #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxHalford
reviewed
Jul 22, 2024
Comment on lines
+133
to
+136
| try: | ||
| database, leftover = table_reference.split(".", 1) | ||
| except ValueError: | ||
| raise Exception("Specify the full path to the table, e.g. 'schema.table'") |
There was a problem hiding this comment.
I think this a useful thing to catch. However, I would add a bit more context. Maybe include the table_reference value to make the error message more informative?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I'm keen to start contributing. I will have a look at some of the issues in the issues list first, but just wanted to start off with something super basic!
Fine for you to close / reject this as it is a little bit pointless :)