Read crs information from metadata
#114
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
| // Respect `projection` prop when provided, otherwise rely on `crs` value from metadata | ||
| this.projectionIndex = projection | ||
| ? ['mercator', 'equirectangular'].indexOf(projection) | ||
| : ['EPSG:3857', 'EPSG:4326'].indexOf(crs) | ||
| this.projection = ['mercator', 'equirectangular'][ | ||
| this.projectionIndex | ||
| ] | ||
|
|
There was a problem hiding this comment.
looks like we default to mercator in the shader in the case of a -1 index, but is there any other reason to handle an invalid index early here? Seems like updateCamera and maybe the region picker stuff might be sad if this.projection ends up undefined.
There was a problem hiding this comment.
Good call! Decided to add a check here to handle either an unexpected crs and projection value. Want to take another look.
| if (!crs) { | ||
| console.warn( | ||
| 'Missing `crs` value in `multiscales` metadata. Please check your pyramid generation code. Falling back to `crs=EPSG:3857` (Web Mercator)' | ||
| ) | ||
| crs = 'EPSG:3857' | ||
| } | ||
| return { levels, maxZoom, tileSize, crs } |
There was a problem hiding this comment.
might be worth adding a check to see if the provided crs is one of our two valid options and to report out those options if not
There was a problem hiding this comment.
Added a consolidated check in tiles.js
This PR updates the library to read the
crsattribute in multiscales metadata [0], when present, to determine theprojectionthe data are stored in. The existingprojectionprop will still take precedence and can be used as an override or to specify a value whencrsis missing.[0] https://ndpyramid.readthedocs.io/en/latest/schema.html
cc @andersy005 @maxrjones