Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch missing webgl extensions #123

Closed
wants to merge 1 commit into from
Closed

Conversation

Shane98c
Copy link
Member

This checks whether extensions exist so we can catch broken regl more gracefully.

First step towards addressing #122

Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
maps-demo ⬜️ Ignored (Inspect) Oct 16, 2024 5:44am
maps-docs ⬜️ Ignored (Inspect) Oct 16, 2024 5:44am

Copy link
Member

@katamartin katamartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one wording nit. This looks good to me otherwise, assuming it's been tested!

setReady(true)
} catch (error) {
console.error('Error initializing WebGL:', error)
setError('Sorry, your device is not supported.')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other elements on the page will still be rendered, right? Maybe we tweak language to be more specific (and consistent with minimaps carbonplan/minimaps#34).

Suggested change
setError('Sorry, your device is not supported.')
setError('Your device doesn't support rendering this map.')

@Shane98c Shane98c closed this Oct 21, 2024
@Shane98c Shane98c deleted the Shane98c/android-warning branch October 21, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants