Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug when node has sub-mountpath delete ,can not remount #195

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

zhangkai8048
Copy link
Contributor

Committer: zhangkai8048 [email protected]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #194

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

only matches volume's paths of its own container

@carina-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhangkai8048

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@carina-ci-bot carina-ci-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S labels Aug 9, 2023
@antmoveh
Copy link
Contributor

antmoveh commented Aug 9, 2023

这个修改是做的啥功能

@zhangkai8048
Copy link
Contributor Author

lgtm l
节点子目录被删除后,原来节点上的pod重启会出现重新挂载失败的情况。所以检查是否挂载这里理论上只检查当前pod使用的volume,忽略节点上其他pod的卷会合适些

@antmoveh
Copy link
Contributor

/lgtm

@carina-ci-bot carina-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2023
@carina-ci-bot carina-ci-bot merged commit e99ac36 into carina-io:main Aug 16, 2023
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S
Projects
None yet
3 participants