-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Series of changes from wire.com #62
Series of changes from wire.com #62
Conversation
use lazy_static::lazy_static; | ||
|
||
#[cfg(feature = "std")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not tracking this change and similar in this file. When I build with cargo hack build --feature-powerset
it fails straightaway when building cargo build --no-default-features
. I did not look at regex source code, but nothing in the docs indicates no-std support presently. How did you envision removing the feature gate here working?
Aside from not seeing how the removal of the std feature gate for regex and url usage should work, this all looks great. Thank you for doing the work and for sharing. I plan to merge as-is tomorrow but you can expect a few changes over the next days/weeks, including:
Once updates for the crates related to the last item are released, I'll likely merge this branch to main and prepare a release of certval for crates.io. |
Hi. Thank you very much. I don't think I'll be able to answer why that was done. Our colleagues that made those changes are not in the company anymore. I'm currently very busy with other tasks and unable to investigate. I'd say go for it and if we see something breaks when we upgrade we come back and discuss what happened. |
Closes #61
Here's a rebased version of our changes. There were conflicts in almost all conflicts. I hope I resolved them correctly.