Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trailing mods to wire PR changes #64

Merged
merged 3 commits into from
Sep 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pittv3/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ remote = ["certval/remote", "revocation", "std"]
pqc = ["pqcrypto-internals", "pqcrypto-dilithium", "pqcrypto-falcon", "pqcrypto-sphincsplus", "pqcrypto", "pqcrypto-traits", "certval/pqc"]
webpki = ["certval/webpki"]
sha1_sig = ["rsa"]
rsa = ["certval/rsa", "dep:rsa"]

[package.metadata.docs.rs]
all-features = true
Expand Down
1 change: 1 addition & 0 deletions pittv3/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ The seven feature gates shared with certval enable varying levels of support and
expressed in CRL DP extensions, and for interacting with OCSP responders via URIs expressed in AIA extensions.
- `pqc` adds support for dilithium, falcon and sphincsplus using algorithm implementations from the [pqcrypto](https://github.com/rustpq/pqcrypto) project and object identifiers from the [IETF 115 PQC hackathon](https://github.com/IETF-Hackathon/pqc-certificates).
- `webpki` adds support for instantiating TaSource instances using trust anchors from the [webpki-roots](https://crates.io/crates/webpki-roots) crate
- `rsa` enables use of the RSA algorithm. RSA support is not enabled by default presently.

The one additional feature gate is `std_app`, which builds certval as `default-features = false` but
builds pittv3 with std support so that end entity files can be selected for validation (additional
Expand Down
6 changes: 3 additions & 3 deletions pittv3/tests/pitt3_std_app.rs
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
#![cfg(not(feature = "std"))]
#![cfg(all(not(feature = "std"), feature = "rsa"))]

use assert_cmd::prelude::*;
use std::process::Command;

#[cfg(feature = "std_app")]
use predicates::prelude::*;

#[cfg(all(feature = "std_app", not(feature = "revocation")))]
#[cfg(all(feature = "std_app", feature = "rsa", not(feature = "revocation")))]
#[test]
fn generate_then_validate_one_std_app() -> Result<(), Box<dyn std::error::Error>> {
{
Expand All @@ -17,7 +17,7 @@ fn generate_then_validate_one_std_app() -> Result<(), Box<dyn std::error::Error>
}
Ok(())
}
#[cfg(all(feature = "std_app", feature = "revocation"))]
#[cfg(all(feature = "std_app", feature = "rsa", feature = "revocation"))]
#[test]
fn generate_then_validate_one_std_app() -> Result<(), Box<dyn std::error::Error>> {
{
Expand Down
Loading