Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved hostname verification #1243

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Improved hostname verification #1243

merged 1 commit into from
Nov 20, 2024

Conversation

caronc
Copy link
Owner

@caronc caronc commented Nov 20, 2024

Description:

Related issue (if applicable): #1234

Improves the Apprise Hostname Validation

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@1234-unparsable-json

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  " json://5t4m82hl-33333.euw.devtunnels.ms"

@caronc caronc force-pushed the 1234-unparsable-json branch from a21a746 to eed9225 Compare November 20, 2024 21:19
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.36%. Comparing base (f37dfbf) to head (eed9225).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1243   +/-   ##
=======================================
  Coverage   99.36%   99.36%           
=======================================
  Files         147      147           
  Lines       20555    20555           
  Branches     3663     3663           
=======================================
  Hits        20425    20425           
  Misses        121      121           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@caronc caronc linked an issue Nov 20, 2024 that may be closed by this pull request
@caronc caronc merged commit 5441c15 into master Nov 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unparseable JSON URL
1 participant