Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for reverse-url construction containing whitespace #1267

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

caronc
Copy link
Owner

@caronc caronc commented Jan 2, 2025

Description:

Related issue (if applicable): #1264

Improved the reverse generation of URLs to handle edge cases with whitespace.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@1264-whitespace-encoding-fix

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.36%. Comparing base (f892936) to head (ca7770e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1267   +/-   ##
=======================================
  Coverage   99.36%   99.36%           
=======================================
  Files         159      159           
  Lines       20715    20718    +3     
  Branches     3724     3724           
=======================================
+ Hits        20584    20587    +3     
  Misses        121      121           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc merged commit d6eb98f into master Jan 2, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant