Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to GitHub Actions example #257

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

jcohen02
Copy link
Contributor

This PR makes updates to the GitHub Actions example to address the error raised in issue #220 and make the suggested changes raised in #256.

Closes #220
Closes #256

@jcohen02 jcohen02 requested a review from aturner-epcc October 21, 2024 22:54
Copy link

github-actions bot commented Oct 21, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/docker-introduction/compare/md-outputs..md-outputs-PR-257

The following changes were observed in the rendered markdown documents:

 docker-hub.md         |   2 +-
 e01-github-actions.md | 114 ++++++++++++++++++++++++++++----------------------
 introduction.md       |  13 ++++++
 md5sum.txt            |   6 +--
 4 files changed, 81 insertions(+), 54 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-10-21 22:56:36 +0000

@jcohen02 jcohen02 requested a review from sstevens2 October 21, 2024 22:55
github-actions bot pushed a commit that referenced this pull request Oct 21, 2024
Copy link
Contributor

@sstevens2 sstevens2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look great to me. Since it is an optional episode, I'm going to be a bit risky and merge it. I've not tested the actions content directly described here but would like to get these changes merged before our workshop starting tomorrow. I'll test it out during the workshop Thursday if not sooner.

@sstevens2 sstevens2 merged commit 42e3400 into carpentries-incubator:main Oct 22, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 22, 2024
Auto-generated via `{sandpaper}`
Source  : 42e3400
Branch  : main
Author  : Sarah Stevens <[email protected]>
Time    : 2024-10-22 15:48:44 +0000
Message : Merge pull request #257 from jcohen02/fix/issue256

Updates to GitHub Actions example
github-actions bot pushed a commit that referenced this pull request Oct 22, 2024
Auto-generated via `{sandpaper}`
Source  : 2b1eca5
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-10-22 15:49:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 42e3400
Branch  : main
Author  : Sarah Stevens <[email protected]>
Time    : 2024-10-22 15:48:44 +0000
Message : Merge pull request #257 from jcohen02/fix/issue256

Updates to GitHub Actions example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants