CI against Rails 7.2 #2755
Open
CI against Rails 7.2 #2755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-yagi
force-pushed
the
ci-against-rails72
branch
2 times, most recently
from
b0eb0cd
to
34fe857
Compare
y-yagi
force-pushed
the
ci-against-rails72
branch
from
34fe857
to
d0c18f7
Compare
y-yagi
commented
Oct 2, 2024
| @@ -8,8 +8,8 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| ruby: [ '2.7', '3.0', '3.1', '3.2', '3.3', jruby ] | |||
There was a problem hiding this comment.
I removed this because activerecord-jdbc-adapter doesn't support Rails 7.1 yet
jruby/activerecord-jdbc-adapter#1146
Instead of this, I added to the matrix for JRuby + gemfiles/rails-7-0.gemfile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Rails 7.2 to the CI matrix to confirm
carrierwaveworking with Rails 7.2.Currently, the latest Rails runs against only the latest Ruby and the previous Rails version runs against multiple Rubies. So I updated the matrix to follow it.