remove jdbc config and add sonar credentials to config example #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my experience the jdbc section in the config is not necessary. Instead we should document how to provide the credentials for SonarQube which are needed as soon as you activate the user authentication in SonarQube.
How I came to this conclusion:
I setup SonarQube (user authentication deactivated) with a MySQL database. Then I scanned my project with the gulp-sonar task using the config from the example but without the jdbc section and it was working totally fine for me.
Later I activated the user authentication in SonarQube and run the gulp task again and (as expected) it failed:
I added the properties login and password to the config object (like described in my PR) and then it was working.