Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: actually use sdk_name #42

Merged
merged 1 commit into from
Jul 11, 2024
+6 −1
Merged

fix: actually use sdk_name #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/long-ligers-perform.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@cartesi/cli": patch
---

fix: actually use sdk_name
2 changes: 1 addition & 1 deletion apps/cli/src/commands/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@
outputFilePath: string,
): Promise<void> {
// create docker tarball from app image
const { stdout: appCid } = await execa("docker", [

Check warning on line 156 in apps/cli/src/commands/build.ts

View workflow job for this annotation

GitHub Actions / lint 

'appCid' is assigned a value but never used
"image",
"save",
image,
Expand Down Expand Up @@ -278,7 +278,7 @@
const imageInfo = await this.getImageInfo(appImage);

// resolve sdk version
const sdkImage = `cartesi/sdk:${imageInfo.sdkVersion}`;
const sdkImage = `${imageInfo.sdkName}:${imageInfo.sdkVersion}`;

try {
// create docker tarball for image specified
Expand Down
Loading