Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional espresso-dev-node to cartesi run #80

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

endersonmaia
Copy link
Contributor

@endersonmaia endersonmaia commented Sep 30, 2024

Depends on: #81

A new minor version cartesi/sdk should be released before merging this PR.


This pull request includes several updates to the @cartesi/cli package, focusing on adding a new feature and updating dependencies. The most important changes include adding the --enable-espresso flag to the cartesi run command, updating Docker Compose configurations to use newer images, and adding support for the Espresso development node.

New Feature:

  • Added --enable-espresso flag to enable the Espresso development node in the cartesi run command (apps/cli/src/commands/run.ts). [1] [2]

Dependency Updates:

  • Updated Docker Compose configurations to use cartesi/sdk:0.11.0 instead of cartesi/sdk:0.10.0 (apps/cli/src/node/docker-compose-anvil.yaml, apps/cli/src/node/docker-compose-bundler.yaml, apps/cli/src/node/docker-compose-paymaster.yaml, packages/mock-verifying-paymaster/docker-compose.yaml). [1] [2] [3] [4] [5] [6]
  • Updated PostgreSQL image to postgres:16-alpine in Docker Compose configurations (apps/cli/src/node/docker-compose-database.yaml, apps/cli/src/node/docker-compose-explorer.yaml). [1] [2]

Support for Espresso Development Node:

  • Added Docker Compose configuration for the Espresso development node (apps/cli/src/node/docker-compose-espresso.yaml).

Documentation:

  • Added a changeset file to document the addition of the --enable-espresso flag (.changeset/fresh-mangos-wink.md).

Copy link

changeset-bot bot commented Sep 30, 2024

🦋 Changeset detected

Latest commit: 5747f64

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cartesi/cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@endersonmaia endersonmaia force-pushed the feature/add-espresso-dev-node branch from 418b8da to 23217fd Compare September 30, 2024 14:44
@endersonmaia
Copy link
Contributor Author

endersonmaia commented Sep 30, 2024

It's possible to start testing with:

cartesi-dev run --disable-bundler --disable-explorer --enable-espresso --verbose

.changeset/odd-phones-grab.md Outdated Show resolved Hide resolved
apps/cli/src/node/docker-compose-database.yaml Outdated Show resolved Hide resolved
apps/cli/src/node/docker-compose-espresso.yaml Outdated Show resolved Hide resolved
espresso-notes.md Outdated Show resolved Hide resolved
@endersonmaia endersonmaia force-pushed the feature/add-espresso-dev-node branch 3 times, most recently from 09cd9a7 to f95e3df Compare October 1, 2024 17:04
@endersonmaia endersonmaia changed the base branch from main to feature/add-espresso-dev-node-to-sdk October 1, 2024 17:06
@endersonmaia endersonmaia self-assigned this Oct 1, 2024
@endersonmaia endersonmaia marked this pull request as ready for review October 1, 2024 17:11
@endersonmaia endersonmaia requested a review from tuler October 1, 2024 17:11
@endersonmaia endersonmaia force-pushed the feature/add-espresso-dev-node-to-sdk branch from bfe1fd4 to 28e9fce Compare January 22, 2025 14:56
@endersonmaia endersonmaia force-pushed the feature/add-espresso-dev-node branch from f95e3df to c749928 Compare January 22, 2025 14:57
Copy link
Contributor

github-actions bot commented Jan 22, 2025

Coverage Report for ./apps/cli

Status Category Percentage Covered / Total
🔵 Lines 31% 293 / 945
🔵 Statements 31.13% 298 / 957
🔵 Functions 36.95% 51 / 138
🔵 Branches 27.88% 121 / 434
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/cli/src/config.ts 89.5% 82.02% 96.77% 89.3% 66-67, 215, 222, 231, 246-249, 260, 269, 271, 280, 318, 328-332, 344
apps/cli/src/commands/run.ts 0% 0% 0% 0% 9-229
Generated in workflow #230 for commit 5747f64 by the Vitest Coverage Report Action

@endersonmaia endersonmaia force-pushed the feature/add-espresso-dev-node-to-sdk branch from 28e9fce to 9dc6320 Compare January 22, 2025 21:18
@endersonmaia endersonmaia force-pushed the feature/add-espresso-dev-node branch 2 times, most recently from 9b870cf to 1b28127 Compare January 23, 2025 11:57
Base automatically changed from feature/add-espresso-dev-node-to-sdk to prerelease/v2-alpha January 23, 2025 14:07
With that option you can start a espresso-dev-node integrated into the
cartesi development environment.
@endersonmaia endersonmaia force-pushed the feature/add-espresso-dev-node branch from 1b28127 to 5747f64 Compare January 23, 2025 14:40
Copy link
Member

@tuler tuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the Postgres upgrade ok really ok?

@endersonmaia
Copy link
Contributor Author

I'll normalize postgres image versions used on another PR.

@endersonmaia endersonmaia merged commit e79c0bb into prerelease/v2-alpha Jan 23, 2025
3 checks passed
@endersonmaia endersonmaia deleted the feature/add-espresso-dev-node branch January 23, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants