-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add machine-emulator
native bindings for Rust
#25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
What are the best practices with FFIs in Rust? Should we commit the bindings.rs
, or generate them in a build script (build.rs
)? If it's the build script route, I guess we'd have to include the header files somewhere. I don't mind committing it for now, and later pulling it from a submodule.
I can never remember, what is the recommendation for committing Cargo.lock
in Rust workspaces? Considering whether there are executables or just libs?
@@ -0,0 +1,31 @@ | |||
//! Defines the [struct@Hash] type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to use the same definition of Hash as Dave is using. Later, I think we could even bring your merkle data structure to this workspace.
Executables should commit the I think that we can only generate the bindings using |
…orcodes and free error message immediately after copying it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Can you give me some pointers on how to use this crate? I want to write a program in Rust that runs the machine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✨✨
No description provided.