New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: split `IConsensus` interface into two #341

Merged

guidanoli merged 3 commits into main from feature/iconsensus-erc165

Jan 30, 2025

Collaborator

guidanoli commented Jan 24, 2025 •

edited

Loading

Create IClaimSubmitter interface
Move definitions from IConsensus to IClaimSubmitter, leaving just the isOutputsMerkleRootValid function (former wasClaimAccepted)
Make IConsensus inherit from ERC-165 interface
Make consensus contracts implement ERC-165 (supporting IClaimSubmitter, IAuthority, and IQuorum, where applicable)
Adjust nomenclature to make it explicit that the claim is the outputs Merkle root

guidanoli added 3 commits

January 28, 2025 11:00


          feat: split IConsensus

6bef3f6


          refactor: claim -> outputs Merkle root

d84f937


          docs: adjust documentation

4de91d6

guidanoli force-pushed the feature/iconsensus-erc165 branch from c2e6d9c to 4de91d6 Compare

January 28, 2025 14:20

guidanoli requested review from ZzzzHui and pedroargento

January 28, 2025 14:27

guidanoli marked this pull request as ready for review

January 28, 2025 14:27

pedroargento approved these changes

View reviewed changes

guidanoli merged commit 505cadd into main

3 checks passed

guidanoli deleted the feature/iconsensus-erc165 branch

January 30, 2025 14:04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet