add max tries and interval #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miltonjonat
reviewed
Feb 4, 2025
There was a problem hiding this comment.
It works in practice, but I think we could improve things a bit:
- Couldn't we use the same policy env vars when attempting to read the DB NodeConfig in
main.go? - Would it make sense to add a test case to show that we correctly handle these misconfiguration situations?
| if err != nil { | ||
| slog.Error("failed fetching latest espresso block height", "error", err) | ||
| continue | ||
| os.Exit(1) |
There was a problem hiding this comment.
Why doesn't it return with an error? Isn't it too strong to exit the whole thing since this is not main.go?
ZzzzHui
force-pushed
the
feature/max-tries-and-interval
branch
from
a68b829 to
e6563b6
Compare
Not sure about this. Retry policy was already tested in its own package |
miltonjonat
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.