#299 Disable existing JSON ABI specification option for generic input form when no specifications are available #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… any available specifications
…aren't any existing specifications
…ups-wagmi from the generic form test suite
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brunomenezes
requested changes
Jan 20, 2025
| rollupsWagmi.useSimulateInputBoxAddInput = vi | ||
| .fn() | ||
| .mockImplementation(mockedHook); | ||
| useSimulateInputBoxAddInputMock.mockImplementation(mockedHook); |
There was a problem hiding this comment.
This useSimulateInputBoxAddInputMock is already a mock. So you don't need to create an external one to pass as an implementation of another mock 🤔 . You could do the mockReturnValue as you did above or in the beforeEach. That also applies to all the other test cases doing the same.
brunomenezes
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides the code changes and new unit tests for it, I also refactored the test suite for the generic form, removing inline imports.