Add support for fuzzy case-insensitive match in PropertyRef #1383
+144
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achantavy
force-pushed
the
fuzzymatch
branch
from
05598cf
to
00cb020
Compare
achantavy
commented
Nov 13, 2024
| class FakeEmp2ToGitHubUser(CartographyRelSchema): | ||
| target_node_label: str = 'GitHubUser' | ||
| target_node_matcher: TargetNodeMatcher = make_target_node_matcher( | ||
| {'username': PropertyRef('github_username', fuzzy_and_ignore_case=True)}, |
There was a problem hiding this comment.
@SecPrez: this will allow us to connect 2 nodes in a "fuzzy" way, lemme know if this helps
achantavy
commented
Nov 13, 2024
| WITH i, item | ||
| OPTIONAL MATCH (n0:GitHubUser) | ||
| WHERE | ||
| toLower(n0.username) CONTAINS toLower(item.github_username) |
There was a problem hiding this comment.
@SecPrez this is what the final rendered query will look like
|
@ramonpetgrave64 - you might be not available but just cc'ing you here anyway since i think you have the most context on this kind of data model change |
|
@heryxpc lemme know what you think too |
achantavy
force-pushed
the
fuzzymatch
branch
from
00cb020
to
5a31913
Compare
Signed-off-by: Alex Chantavy <[email protected]>
Signed-off-by: Alex Chantavy <[email protected]>
achantavy
force-pushed
the
fuzzymatch
branch
from
e995a65
to
8c514e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We often need to connect 2 nodes based on a fuzzy match like in #1380 (comment). This PR adds a
fuzzy_and_ignore_caseoption to thePropertyRefso that the final rendered query performs aCONTAINSin a case-insensitive way instead of an exact match.Related issues or links
#1380
Checklist
Provide proof that this works (this makes reviews move faster). Please perform one or more of the following: