Fix race condition for Docker local tests #1384
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before:
Pull down a fresh cartography from github
Build the container with
docker build -t cartography-cncf/cartography-dev -f dev.Dockerfile ./
(I forgot to screenshot this step)Running the docker-compose linter works on the first try because the initialization step takes a while:
[Failure] But subsequent linter runs fail with "is this a git repository?"
After:
Pull down fresh cartography from github and checkout this fix branch (fixdcwait)
Build container
Run linter on the first try
[SUCCESS] Subsequent linter runs work because we've added a waiting mechanism
Related issues or links
Checklist
Provide proof that this works (this makes reviews move faster). Please perform one or more of the following: