Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: bump starknet-rs to 0.11.0 + migrate to the new Felt type #40

Merged
merged 16 commits into from
Jul 3, 2024

Conversation

kariy
Copy link
Member

@kariy kariy commented Jun 20, 2024

UPDATE: waiting on xJonathanLEI/starknet-rs#612

Changes:

  • use versioned execution types; replacing all references to Account::execute() and Execution (which are now considered deprecated) to the Account::execute_v1() and ExecutionV1 respectively.

https://github.com/xJonathanLEI/starknet-rs/blob/016f3ee3293c8355f8a7cb64777adea6119493b9/starknet-accounts/src/account/mod.rs#L58-L60

  • replace the old FieldElement to Felt.
  • downstream uses of abigen! now requires adding the num-traits crate as a dependencies.

@xJonathanLEI
Copy link

You need a patch release on starknet-core?

@kariy
Copy link
Member Author

kariy commented Jun 20, 2024

You need a patch release on starknet-core?

yes, that'd be very helpful

@xJonathanLEI
Copy link

starknet-core v0.11.1 is now available on crates.io.

@kariy kariy marked this pull request as ready for review June 26, 2024 15:25
@kariy kariy requested a review from glihm June 26, 2024 15:27
@kariy kariy changed the title Bump starknet-rs to 0.11.0 + migrate to the new Felt type breaking: bump starknet-rs to 0.11.0 + migrate to the new Felt type Jun 26, 2024
Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the work here @kariy! 🚀

@glihm glihm merged commit e67d925 into main Jul 3, 2024
5 checks passed
@kariy kariy deleted the bump-starknet-rs branch July 3, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants