Support login with no policies

cartridge-gg · Jan 24, 2025 · 31007b5 · 31007b5
1 parent a7147f5
commit 31007b5
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 20 deletions.
diff --git a/examples/next/src/components/providers/StarknetProvider.tsx b/examples/next/src/components/providers/StarknetProvider.tsx
@@ -123,7 +123,6 @@ const controller = new ControllerConnector({
   // slot: "profile-example",
   slot: "ryomainnet",
   preset: "dope-wars",
-  namespace: "dopewars",
   // namespace: "dopewars",
   // slot: "eternum-prod",
   // preset: "eternum",

diff --git a/packages/keychain/src/components/home.tsx b/packages/keychain/src/components/home.tsx
@@ -28,8 +28,8 @@ export function Home() {
       controller.isRequestedSession(policies).then((isRequestedSession) => {
         setHasSessionForPolicies(isRequestedSession);
       });
-    } else {
-      setHasSessionForPolicies(undefined);
+    } else if (controller && !policies) {
+      setHasSessionForPolicies(true);
     }
   }, [controller, policies]);
 
@@ -80,16 +80,6 @@ export function Home() {
         return <></>;
       }
 
-      if (hasSessionForPolicies) {
-        context.resolve({
-          code: ResponseCodes.SUCCESS,
-          address: controller.address,
-          policies: policies,
-        });
-
-        return <></>;
-      }
-
       // TODO: show missing policies if mismatch
       return (
         <CreateSession

diff --git a/packages/keychain/src/components/provider/posthog.tsx b/packages/keychain/src/components/provider/posthog.tsx
@@ -1,4 +1,4 @@
-import { PropsWithChildren, useEffect } from "react";
+import { PropsWithChildren, useEffect, useState } from "react";
 import { PostHogContext, PostHogWrapper } from "@/context/posthog";
 import { useConnectionValue } from "@/hooks/connection";
 
@@ -11,17 +11,25 @@ export function PostHogProvider({ children }: PropsWithChildren) {
     autocapture: false,
   });
 
+  // Track the last identified address
+  const [lastIdentifiedAddress, setLastIdentifiedAddress] = useState<string>();
+
   useEffect(() => {
     if (controller) {
-      posthog.identify(controller.username(), {
-        address: controller.address,
-        class: controller.classHash(),
-        chainId: controller.chainId,
-      });
+      // Only identify if this is a new address
+      if (lastIdentifiedAddress !== controller.address) {
+        posthog.identify(controller.username(), {
+          address: controller.address,
+          class: controller.classHash(),
+          chainId: controller.chainId,
+        });
+        setLastIdentifiedAddress(controller.address);
+      }
     } else {
       posthog.reset();
+      setLastIdentifiedAddress(undefined);
     }
-  }, [posthog, controller]);
+  }, [posthog, controller, lastIdentifiedAddress]);
 
   useEffect(() => {
     if (origin) {