Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity page #1057

Merged
merged 5 commits into from
Nov 22, 2024
Merged

Activity page #1057

merged 5 commits into from
Nov 22, 2024

Conversation

JunichiSugiura
Copy link
Collaborator

@JunichiSugiura JunichiSugiura commented Nov 22, 2024

#504

Screenshot 2024-11-22 at 15 28 23
This PR adds activity page with ERC20 transfer entries via tokenTransfers query as the first iteration. Data is limit to 30 entries and "See more" button appears.

Plan is to move to activities query and replace "See more" button with infinite scroll in the future.

Side effects

  • <Spinner /> is added
  • <LayoutContentLoader /> and <LayoutContentError /> is added in layout for bootstrapping a new page.
  • <IndexerAPIProvider /> has been simplified

For debugging

  • packages/profile/.env.development
VITE_CARTRIDGE_API_URL="https://api.cartridge.gg"
VITE_KEYCHAIN_URL="https://x.cartridge.gg"
VITE_RPC_SEPOLIA="https://api.cartridge.gg/x/starknet/sepolia"
VITE_POSTHOG_KEY=phc_UWaJajNQ00PjHhveZ81SJ2zVtBicKrzewdZHGiyavQQ
VITE_POSTHOG_HOST=https://profile.cartridge.gg/ingest
  • packages/keychain/.env.development
NEXT_PUBLIC_ORIGIN="http://localhost:3001"
NEXT_PUBLIC_RP_ID="localhost"
NEXT_PUBLIC_ADMIN_URL="http://localhost:3002"
NEXT_PUBLIC_CARTRIDGE_API_URL="http://localhost:8000"
# NEXT_PUBLIC_ETH_RPC_MAINNET="https://eth-mainnet.g.alchemy.com/v2/OGPRMquXP3K7oTkLrmVZpjCd1DswtYz3"
# NEXT_PUBLIC_ETH_RPC_SEPOLIA="https://eth-sepolia.g.alchemy.com/v2/mURnclB5pn5elDfyzgTN4W2GR-rOYevI"
# NEXT_PUBLIC_RPC_MAINNET="http://localhost:8001/x/starknet/mainnet"
NEXT_PUBLIC_RPC_SEPOLIA="http://localhost:8001/x/starknet/sepolia"
NEXT_PUBLIC_STRIPE_PAYMENT="http://localhost:8000/stripe/payment-intent"
NEXT_PUBLIC_POSTHOG_KEY=phc_UWaJajNQ00PjHhveZ81SJ2zVtBicKrzewdZHGiyavQQ
NEXT_PUBLIC_POSTHOG_HOST=https://x.cartridge.gg/ingest
  • mock address in packages/profile/src/components/activity.tsx
    e.g. 0x04645f67e3e195420b2b4e63742153623e50c143ed8b89c91e3fb908fe87b168
  • Controller option
    slot: "ls-erc"

Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview Nov 22, 2024 2:21pm
ui-next ✅ Ready (Inspect) Visit Preview Nov 22, 2024 2:21pm

Copy link
Contributor

@bal7hazar bal7hazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works well
LGTM

@JunichiSugiura JunichiSugiura merged commit bfe69cf into main Nov 22, 2024
18 checks passed
@JunichiSugiura JunichiSugiura deleted the feat(profile)/#504-activity-graphql branch November 22, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants