Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(profile)/transfer #1124

Merged
merged 22 commits into from
Dec 16, 2024
Merged

Feat(profile)/transfer #1124

merged 22 commits into from
Dec 16, 2024

Conversation

bal7hazar
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Dec 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview Dec 16, 2024 3:18pm
ui-next ✅ Ready (Inspect) Visit Preview Dec 16, 2024 3:18pm

@bal7hazar bal7hazar marked this pull request as ready for review December 10, 2024 17:35
@bal7hazar bal7hazar enabled auto-merge (squash) December 10, 2024 17:35
@tarrencev tarrencev requested a review from broody December 10, 2024 20:11
@bal7hazar bal7hazar disabled auto-merge December 10, 2024 22:44
JunichiSugiura
JunichiSugiura requested changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@JunichiSugiura JunichiSugiura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for refining this flow. Code looks good to me. Just need to test it but not sure how to solve the iframe issue in the preview on this PR. Unless we find a quick solution, maybe we should merge and test in main branch preview with Sepolia account right after. We need to disable the sending button in case when games uses old version of controller without sendBackward/foward method tho.

packages/controller/src/controller.ts Outdated Show resolved Hide resolved
packages/profile/src/components/inventory/token/send.tsx Outdated Show resolved Hide resolved
packages/profile/src/components/inventory/token/send.tsx Outdated Show resolved Hide resolved
broody
broody approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@broody broody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Erc20 transf erworks locally for me, I think should be fine to release and address comments

@JunichiSugiura
Copy link
Collaborator

Let me remove feature flag for now

JunichiSugiura
JunichiSugiura approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@JunichiSugiura JunichiSugiura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bal7hazar bal7hazar merged commit cd38a36 into main Dec 16, 2024
18 checks passed
@bal7hazar bal7hazar deleted the feat(profile)/transfer branch December 16, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarrencev tarrencev tarrencev left review comments

@JunichiSugiura JunichiSugiura JunichiSugiura approved these changes

@broody broody broody approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bal7hazar @JunichiSugiura @broody @tarrencev