Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plug together Arcade and Profile and enable Pin and Share features #1260

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Plug together Arcade and Profile and enable Pin and Share features #1260

wants to merge 15 commits into from

Conversation

bal7hazar
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Jan 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ui-next ✅ Ready (Inspect) Visit Preview Jan 15, 2025 2:34pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

⚠️ Visual Differences Detected

The following components have visual differences that need review:

components-connect-createsession--default-chromium

components-connect-createsession--default-chromium

⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

🎨 Visual Regression Test Results

✅ No visual changes detected

@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

⚠️ Visual Differences Detected

The following components have visual differences that need review:

components-connect-createsession--default-chromium

components-connect-createsession--default-chromium

⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

⚠️ Visual Differences Detected

The following components have visual differences that need review:

components-connect-createsession--default-chromium

components-connect-createsession--default-chromium

⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

⚠️ Visual Differences Detected

The following components have visual differences that need review:

components-connect-createsession--default-chromium

components-connect-createsession--default-chromium

⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

⚠️ Visual Differences Detected

The following components have visual differences that need review:

components-connect-createsession--default-chromium

components-connect-createsession--default-chromium

⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

⚠️ Visual Differences Detected

The following components have visual differences that need review:

components-connect-createsession--default-chromium

components-connect-createsession--default-chromium

⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

⚠️ Visual Differences Detected

The following components have visual differences that need review:

components-connect-createsession--default-chromium

components-connect-createsession--default-chromium

⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

⚠️ Visual Differences Detected

The following components have visual differences that need review:

components-connect-createsession--default-chromium

components-connect-createsession--default-chromium

⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

⚠️ Visual Differences Detected

The following components have visual differences that need review:

components-connect-createsession--default-chromium

components-connect-createsession--default-chromium

⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

@bal7hazar bal7hazar marked this pull request as ready for review January 14, 2025 11:13
@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

⚠️ Visual Differences Detected

The following components have visual differences that need review:

components-connect-createsession--default-chromium

components-connect-createsession--default-chromium

⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

@bal7hazar bal7hazar requested a review from tarrencev January 14, 2025 11:20
bal7hazar
bal7hazar commented Jan 14, 2025
View reviewed changes
examples/next/package.json
@@ -3,7 +3,7 @@
"private": true,
"version": "0.5.8",
"scripts": {
"dev": "next dev -p 3002",
"dev": "next dev -p 3002 --experimental-https",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turning the example to HTTPS so we can actually test the prod directly and avoid this:
image

@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

⚠️ Visual Differences Detected

The following components have visual differences that need review:

components-connect-createsession--default-chromium

components-connect-createsession--default-chromium

⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

@bal7hazar bal7hazar marked this pull request as draft January 14, 2025 14:41
@bal7hazar bal7hazar marked this pull request as ready for review January 15, 2025 13:19
@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

✅ No visual changes detected

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

✅ No visual changes detected

@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

✅ No visual changes detected

@bal7hazar bal7hazar enabled auto-merge (squash) January 15, 2025 14:08
@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

✅ No visual changes detected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarrencev tarrencev Awaiting requested review from tarrencev

@broody broody Awaiting requested review from broody

@JunichiSugiura JunichiSugiura Awaiting requested review from JunichiSugiura

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bal7hazar