Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message policy support chain switching #1265

Merged
merged 14 commits into from
Jan 10, 2025
Merged

Message policy support chain switching #1265

merged 14 commits into from
Jan 10, 2025

Conversation

broody
Copy link
Contributor

@broody broody commented Jan 9, 2025

To support chain switching with messages, removed chain id violation check on frontend. Pass to create session only messages with domain chain id matching current the chain

Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ui-next ✅ Ready (Inspect) Visit Preview Jan 10, 2025 7:10pm

@broody broody changed the title Support chain switching Message policy support support chain switching Jan 9, 2025
@broody broody force-pushed the message-chainswitching branch from 7ac816a to 4f93d26 Compare January 9, 2025 23:12
@broody broody changed the title Message policy support support chain switching Message policy support chain switching Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

⚠️ Visual Differences Detected

The following components have visual differences that need review:

components-connect-createsession--default-chromium

components-connect-createsession--default-chromium


⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

1 similar comment
Copy link
Contributor

github-actions bot commented Jan 9, 2025

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

⚠️ Visual Differences Detected

The following components have visual differences that need review:

components-connect-createsession--default-chromium

components-connect-createsession--default-chromium


⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

⚠️ Visual Differences Detected

The following components have visual differences that need review:

components-connect-createsession--default-chromium

components-connect-createsession--default-chromium


⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

Base automatically changed from chainswitching to main January 10, 2025 18:51
Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

⚠️ Visual Differences Detected

The following components have visual differences that need review:

components-connect-createsession--default-chromium

components-connect-createsession--default-chromium


⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

@broody broody merged commit dd3e663 into main Jan 10, 2025
16 checks passed
@broody broody deleted the message-chainswitching branch January 10, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants