Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Credits funding for slot #1272

Merged
merged 5 commits into from
Jan 15, 2025
Merged

Credits funding for slot #1272

merged 5 commits into from
Jan 15, 2025
+86 −44

Conversation

broody
Copy link
Contributor

@broody broody commented Jan 13, 2025

No description provided.

@vercel Vercel
Copy link

vercel bot commented Jan 13, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ui-next ✅ Ready (Inspect) Visit Preview Jan 15, 2025 7:47pm

@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

✅ No visual changes detected

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

✅ No visual changes detected

@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

⚠️ Visual Differences Detected

The following components have visual differences that need review:

components-connect-createsession--default-chromium

components-connect-createsession--default-chromium

components-funding-purchasecredits--default-chromium

components-funding-purchasecredits--default-chromium

⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

⚠️ Visual Differences Detected

The following components have visual differences that need review:

components-connect-createsession--default-chromium

components-connect-createsession--default-chromium

components-funding-purchasecredits--default-chromium

components-funding-purchasecredits--default-chromium

⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

@broody broody marked this pull request as ready for review January 14, 2025 00:58
@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

⚠️ Visual Differences Detected

The following components have visual differences that need review:

components-connect-createsession--default-chromium

components-connect-createsession--default-chromium

components-funding-purchasecredits--default-chromium

components-funding-purchasecredits--default-chromium

⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

⚠️ Visual Differences Detected

The following components have visual differences that need review:

components-funding-purchasecredits--default-chromium

components-funding-purchasecredits--default-chromium

components-deploycontroller--default-chromium

components-deploycontroller--default-chromium

components-funding--default-chromium

components-funding--default-chromium

⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

@tarrencev
Copy link
Contributor

Please run scripts/update-storybook-snapshot.sh to update the snapshots

@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

🔄 Snapshot Updates in PR

The following snapshots have been updated in this PR:

components-deploycontroller--default-chromium

components-deploycontroller--default-chromium

components-funding--default-chromium

components-funding--default-chromium

components-funding-purchasecredits--default-chromium

components-funding-purchasecredits--default-chromium

@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

⚠️ Visual Differences Detected

The following components have visual differences that need review:

components-funding-purchasecredits--default-chromium

components-funding-purchasecredits--default-chromium

🔄 Snapshot Updates in PR

The following snapshots have been updated in this PR:

components-deploycontroller--default-chromium

components-deploycontroller--default-chromium

components-funding--default-chromium

components-funding--default-chromium

components-funding-purchasecredits--default-chromium

components-funding-purchasecredits--default-chromium

⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

🔄 Snapshot Updates in PR

The following snapshots have been updated in this PR:

components-deploycontroller--default-chromium

components-deploycontroller--default-chromium

components-funding--default-chromium

components-funding--default-chromium

components-funding-purchasecredits--default-chromium

components-funding-purchasecredits--default-chromium

@broody broody merged commit 383f106 into main Jan 15, 2025
16 checks passed
@broody broody deleted the slot-fund branch January 15, 2025 20:15
@broody broody restored the slot-fund branch January 15, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarrencev tarrencev tarrencev left review comments

@steebchen steebchen steebchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@broody @tarrencev @steebchen