Improve policy list scrolling #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Looks slick! Didn't know you were hiding these skills It would be really sick if when you scrolled up the pane header went all the way to the top of the frame before sticking Also could be a cool behavior if you could scroll it open from the collapsed position, so you don't need to click the button. On mobile you could just pull up the bottom pane |
|
The author of this PR, kariy, is not an activated member of this organization on Codecov. |
JunichiSugiura
force-pushed
the
fix-policies-scrolling
branch
from
d66e6ab to
a193b1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before 🤢👎:
Cartridge.Controller.-.7.June.2024.mp4
After 😎🤯:
Cartridge.Controller.-.8.June.2024.mp4
EDIT: just realized the weird bounce when opening the drawer. fixing it.Fixed