Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip CreateSession if no policy is provided #592

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

JunichiSugiura
Copy link
Collaborator

@JunichiSugiura JunichiSugiura commented Aug 16, 2024

close #587

Breaking changes

Controller policies are moved to ControllerOptions.

Connector constructor now accepts only 1 argument.

constructor(options?: ControllerOptions) {

*This PR requires new version to be published

Copy link

vercel bot commented Aug 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cartridge-starknet-react-next ✅ Ready (Inspect) Visit Preview Aug 20, 2024 0:20am
docs ✅ Ready (Inspect) Visit Preview Aug 20, 2024 0:20am
keychain ✅ Ready (Inspect) Visit Preview Aug 20, 2024 0:20am
ui ✅ Ready (Inspect) Visit Preview Aug 20, 2024 0:20am
ui-next ✅ Ready (Inspect) Visit Preview Aug 20, 2024 0:20am

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.35%. Comparing base (679bdca) to head (2bf66a4).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #592   +/-   ##
=======================================
  Coverage   19.35%   19.35%           
=======================================
  Files           3        3           
  Lines          31       31           
  Branches        7        7           
=======================================
  Hits            6        6           
  Misses         25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JunichiSugiura JunichiSugiura requested a review from broody August 16, 2024 16:00
@JunichiSugiura JunichiSugiura marked this pull request as ready for review August 16, 2024 16:01
@broody
Copy link
Contributor

broody commented Aug 16, 2024

Signup works great, we just need to do the same for login.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Controller to support no policies
2 participants