-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip CreateSession if no policy is provided #592
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JunichiSugiura
force-pushed
the
fix(keychain)/no-policy
branch
from
August 16, 2024 15:41
7163560
to
fbd94c1
Compare
JunichiSugiura
force-pushed
the
fix(keychain)/no-policy
branch
from
August 16, 2024 15:49
fbd94c1
to
2bf66a4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #592 +/- ##
=======================================
Coverage 19.35% 19.35%
=======================================
Files 3 3
Lines 31 31
Branches 7 7
=======================================
Hits 6 6
Misses 25 25 ☔ View full report in Codecov by Sentry. |
JunichiSugiura
force-pushed
the
fix(keychain)/no-policy
branch
from
August 20, 2024 12:16
ee49d04
to
5318c6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #587
Breaking changes
Controller policies are moved to
ControllerOptions
.Connector
constructor now accepts only 1 argument.controller/packages/connector/src/index.ts
Line 9 in 2bf66a4
*This PR requires new version to be published