Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📜 Feat(quest)/integration #895

Merged
merged 34 commits into from
Oct 24, 2024
Merged

📜 Feat(quest)/integration #895

merged 34 commits into from
Oct 24, 2024

Conversation

bal7hazar
Copy link
Contributor

@bal7hazar bal7hazar commented Oct 21, 2024 •
edited
Loading

Integration of the trophies in the profile page.

Some info:

  • Quest has been renamed into Trophies because we actually focus on achievements and not on the flow to unlock them (only the description is here to help the user, but the quest itself will be handled on the game side).
  • The data is hardcoded for now, the next PR regarding trophies will be the connection with the data.
  • I have added a dedicated graphql query for the AccountName, but actually the field name is empty and we use the field id, but in the future we should rely on the name and not the id.
  • I have modified the default behavior of the ScrollArea primitive to have the scrollbar hidden always except on scroll (and fad out after few hundred ms).
  • I have added few icons coming from figma
  • I have added few colours without refactoring it all, but at some point we should consider to realign it with figma and remove the offset (secondary -> primary, quaternary -> secondary, etc.)

@vercel Vercel
Copy link

vercel bot commented Oct 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Oct 24, 2024 8:43am
ui ✅ Ready (Inspect) Visit Preview Oct 24, 2024 8:43am
ui-next ✅ Ready (Inspect) Visit Preview Oct 24, 2024 8:43am

@bal7hazar bal7hazar marked this pull request as ready for review October 23, 2024 13:45
@bal7hazar bal7hazar changed the title 🚧 Feat(quest)/integration 📜 Feat(quest)/integration Oct 23, 2024
JunichiSugiura
JunichiSugiura approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@JunichiSugiura JunichiSugiura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was fast and looks clean, LGTM !

packages/profile/src/components/navigation.tsx Outdated Show resolved Hide resolved
packages/profile/src/components/trophies/index.tsx Outdated Show resolved Hide resolved
packages/profile/src/components/trophies/leaderboard.tsx Outdated Show resolved Hide resolved
packages/profile/src/components/trophies/leaderboard.tsx Outdated Show resolved Hide resolved
packages/profile/src/components/trophies/pinned.tsx Outdated Show resolved Hide resolved
packages/ui-next/src/themes/dark.css Show resolved Hide resolved
bal7hazar and others added 2 commits October 24, 2024 10:40
@bal7hazar
🐛 Minor changes according to review feedbacks
17b7463
@tarrencev @bal7hazar
Migrate to WalletAccount api (#897)
cf53411 
* Migrate to WalletAccount api

* Update Session + Telegram implementations

* Disable playwright

* Abstract provider implementation

* Use url encoded policies
@bal7hazar bal7hazar merged commit 16d566c into main Oct 24, 2024
19 checks passed
@bal7hazar bal7hazar deleted the feat(quest)/integration branch October 24, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JunichiSugiura JunichiSugiura JunichiSugiura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bal7hazar @JunichiSugiura @tarrencev