Merge katana integration changes
#1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kariy
added a commit
to dojoengine/dojo
that referenced
this pull request
Jan 28, 2025
The main idea of this PR is **(1)** to define concrete types for the different ways the node chain spec can be configured, and **(2)** implement different genesis initialization procedures based on the chain spec types. We define two separate chain spec types (but combined as an enum when it is consumed by the node):- 1. `katana_chain_spec::dev::ChainSpec` - Use the same genesis initialization function as it is now. - No execution, genesis block and states are embedded directly into the database. - Node running with this chain spec type is not meant to be provable (as the block 0 is not provable). 2. `katana_chain_spec::rollup::ChainSpec` - Initialized by executing the block returned by `rollup::ChainSpec::block()`. - The block contains valid, executable transactions generated from the chain spec's genesis. - The transactions are guaranteed to be valid when they are executed by `snos`*, as they are meant to be provable. By defining these types separately, the node can handle the different setup processes more clearly. --- \* Our version of [`snos`](cartridge-gg/snos#1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assumption(s):-
0x2e7442625bab778683501c0eadbc1ea17b3535da040a12ac7d281066e915eeakatana inithas the same fee token, and there's only 1 token as opposed to 2, for Starknet chains.VersionedConstant, otherwise this would result in mismatch outcome (esp in terms of fee calculation).v0.13.3, and this is matched bykatana.