Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding workflow to update go #489

Closed
wants to merge 3 commits into from
Closed

Adding workflow to update go #489

wants to merge 3 commits into from

Conversation

rohitagg2020
Copy link

Adding workflow to update go

Signed-off-by: Rohit Aggarwal <[email protected]>
Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order for this to do a full update we maybe should update our actions to use:

    - name: Set Up Go
      uses: actions/setup-go@v5
      with:
        go-version-file: go.mod
        check-latest: true

To ensure that we do not need to update the github actions in a separate commit.
Can you please do the change in all the github actions that need it?

@rohitagg2020
Copy link
Author

In order for this to do a full update we maybe should update our actions to use:

    - name: Set Up Go
      uses: actions/setup-go@v5
      with:
        go-version-file: go.mod
        check-latest: true

To ensure that we do not need to update the github actions in a separate commit. Can you please do the change in all the github actions that need it?

Sounds good

@rohitagg2020 rohitagg2020 closed this by deleting the head repository Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants