Created BaseEffector class and different methods inherits from it #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added BaseEffector class inorder to remove the duplicate code.Apart from it all the specific classes AllowOverrideEffector, DenyOverrideEffector, AllowAndDenyEffector, and PriorityEffector) inherits from BaseEffector.
Update default_effectors.py
|
@Nekotoxin please review |
|
|
|
@Akshat111111 plz fix CI:
|
leeqvip
reviewed
Oct 19, 2023
|
Good point, closed for now |
|
But its reducing the complexity and enhancing the performance as well as readability. |
Yeah I am working on it. |
|
@Akshat111111 work on exsiting issues, they are more meaningful. Don't create trivial problem by yourself and resolve it just to be a contributor |
|
Sure I will work on it,But this change I thought will make the code better that's why made this changes. |
|
@Akshat111111 We normally don't accept trivial PRs and don't want to encourage people to do so |
|
I understand it, and will now work on the present issues only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added BaseEffector class inorder to remove the duplicate code.Apart from it all the specific classes AllowOverrideEffector, DenyOverrideEffector, AllowAndDenyEffector, and PriorityEffector) inherits from BaseEffector.