Revise Make descent order #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This applies a Make pattern of depending on a phony Make target instead of a flag file, to guarantee dependents of the monolothic ontology builds are visited after the builds. This has been used in CASE-Corpora for some time, and also helps avoid an issue where updating the Git submodules (such as in bumping the prerelease pointers) necessitated manually deleting the flag file. No effects were observed on Make-managed files. Signed-off-by: Alex Nelson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit documents this PR's purpose.
As a matter of Make orchestration programming, I will handle merging this myself once CI passes. I've already run this once after bumping submodule pointers around and was satisfied with the rebuild steps.