-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bazel build support for swift-snapshot-testing #191
Conversation
b28ea4c
to
df562e7
Compare
I think I'd rather be explicit about this ( |
Ah that's fair, I was copying the Package setup but we can make this explicit on the impl used. |
df562e7
to
61a3519
Compare
@NickEntin I updated this to move the Bazel users can depend on either Also updated the README with Bazel instructions |
3169bd8
to
0cce641
Compare
0cce641
to
f234c83
Compare
Refactors the Bazel support to better match the Package.swift structure: - Makes the following targets available: `AccessibilitySnapshotCore`, `AccessibilitySnapshotCore_ObjC`, `FBSnapshotTestCase_Accessibility`, `FBSnapshotTestCase_Accessibility_ObjC`, `AccessibilitySnapshot`. - The module `AccessibilitySnapshot` uses `swift-snapshot-testing` and the `FBSnapshotTestCase_Accessibility*` modules use `iOSSnapshotTestCase`. - Adds custom BUILD file for `swift-snapshot-testing` to allow it to build with Bazel. I opted for this vs. registry because it's a simple BUILD files.
f234c83
to
ba69788
Compare
Refactors the Bazel support to better match the Package.swift structure:
AccessibilitySnapshot_SnapshotTesting
usesswift-snapshot-testing
and theAccessibilitySnapshot_iOSSnapshotTestCase
modules useiOSSnapshotTestCase
.swift-snapshot-testing
to allow it to build with Bazel. I opted for this vs. registry because it's a simple BUILD files.includes
so downstream targets can include the AccessibilitySnapshot headers via#import <>
.