Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iOS 14.2 to snapshot test matrix #52

Merged
merged 7 commits into from
Jan 5, 2021

Conversation

NickEntin
Copy link
Collaborator

No description provided.

@NickEntin
Copy link
Collaborator Author

Ugh, SnapshotTestingTests.testInvertColors is giving me different results when I step through it with a debugger vs. run it regularly... and neither are correct 🙃

@NickEntin
Copy link
Collaborator Author

Now I'm getting the correct result when I step through it with a debugger (the snapshot I just added), but when it run it normally I still just get an all-black image.

@NickEntin NickEntin marked this pull request as ready for review January 5, 2021 06:59
@NickEntin
Copy link
Collaborator Author

I manually compared these snapshot against the demo app, and they all match with a few exceptions:

Tableware.-.iOS.14.2.1.mov

@NickEntin
Copy link
Collaborator Author

I'm removing Travis CI as a required build since it isn't running the .com version right now (the .org version is passing, but will stop working soon). Hopefully we can migrate the iOS 12 tests over to GH Actions with #43.

Merging this now, then I'll add the iOS 14 CI build as a required PR check.

@NickEntin NickEntin merged commit a272d86 into cashapp:master Jan 5, 2021
@NickEntin NickEntin deleted the entin/ios-14-tests branch January 5, 2021 20:53
@NickEntin NickEntin added the build system Issues related to the build itself and not the functionality of the framework label Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build system Issues related to the build itself and not the functionality of the framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants